[ws_health_exporter] Fix molecule idempotence test failure#98
Merged
Conversation
… false The service can crash in between runs (e.g. if websocket endpoints become unavailable), leaving it in a failed state. Using state: started fails to recover a failed service, and daemon_reload always reports changed. Fix by using state: restarted with daemon_reload and suppressing the changed status with changed_when: false, since this task is purely ensuring the service is running.
…unning service state: restarted causes the service to restart on every run, which disrupts the running exporter and causes the verify health check to fail. Keep state: started with daemon_reload (needed to recover from failed state) but add changed_when: false to pass the idempotence check.
… in Docker The exporter can crash between the idempotence and verify steps in the Docker test environment when websocket endpoints become temporarily unavailable. Restart it before the health check to ensure a clean state.
The exporter was crash-looping because marshmallow 4.0 removed the __version_info__ attribute that environs 9.5.0 depends on. Pin marshmallow<4 to restore compatibility, revert verify.yml to original (no restart/debug needed), keep changed_when: false on the start task for idempotence.
nprt
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues:
marshmallow4.0 brokeenvirons:marshmallow4.0 removed__version_info__, whichenvirons==9.5.0depends on at import time. This caused the exporter to crash-loop on startup. Fix: pinmarshmallow<4.daemon_reload: trueon the start task always reportschanged. Fix: addchanged_when: falsesince this task just ensures the service is running.