feat!: keep WP Application Passwords available by default#70
Merged
Conversation
Application Passwords are the auth mechanism for REST/MCP integrations (portadesign-mcp), which projects are adopting fleet-wide. Flip the StarterBase::$disable_application_passwords default to false; sites without such an integration can opt back into the hardened behavior with a one-line override in their theme Base. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017xUQ7PWZU4zbQUBP26pak6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From-Project: mairateam — enabling Application Passwords for the portadesign-mcp plugin required a per-project override of
disable_application_passwords; the same need applies to every project adopting MCP.Why:
StarterBaseshipsdisable_application_passwords = trueas security hardening ("rarely used in practice"). That assumption no longer holds: Application Passwords are the authentication mechanism for REST/MCP integrations, which we now need fleet-wide. Keeping the hardened default would mean copy-pasting the override into every downstream theme.What: Default flips to
false— Application Passwords stay available out of the box. Deliberate breaking (behavioral) change; accepted trade-off. Sites with no MCP/REST integration opt back in withprotected bool $disable_application_passwords = true;in their themeBase. No other hardening flag changes. CHANGELOG entry under Unreleased marks it BREAKING; suggest releasing as 1.17.0.Tests:
RegisterSecurityHardeningHooksTestsets the flag explicitly via reflection, so it is default-agnostic and keeps passing.🤖 Generated with Claude Code
https://claude.ai/code/session_017xUQ7PWZU4zbQUBP26pak6