fix(scripture-editor): respect dark mode in model/resource panel empty states#2467
Open
merchako wants to merge 1 commit into
Open
fix(scripture-editor): respect dark mode in model/resource panel empty states#2467merchako wants to merge 1 commit into
merchako wants to merge 1 commit into
Conversation
…y states
The model text and Bible texts/commentaries panels render empty-state
prompts ("No model text selected…" / "No Bible texts selected…") that did
not respect the active dark theme.
Their webview stylesheets (model-text-panel.web-view.scss and
resource-text-panel.web-view.scss) omitted `@use './tailwind';`, which the
main editor stylesheet includes. That import defines the theme CSS variables
(`--background`, `--foreground`, the `.dark` block) and the base rule
`body { @apply tw:bg-background tw:text-foreground; }`. Without it, the
panel body never picked up the theme-aware background/text colors, so the
empty-state text ignored dark mode.
Add the tailwind import to both panel stylesheets to match the editor.
Co-authored-by: Claude <noreply@anthropic.com>
Session-URL: https://claude.ai/code/session_01GyVicRy5VvNPxgyryovrgV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Model text panel and the Bible texts / Commentaries panels show empty-state prompts ("No model text selected. Pick one to display a reference translation alongside your project." / "No Bible texts selected. Pick one to display a reference translation alongside your project.") that did not respect the active dark theme.
Root cause
The two panel webview stylesheets omitted the tailwind import that the main editor stylesheet has:
platform-scripture-editor.web-view.scss→@use './tailwind';✅model-text-panel.web-view.scss→ missing ❌resource-text-panel.web-view.scss(shared by Bible texts + Commentaries) → missing ❌tailwind.cssis what defines the theme CSS variables (--background,--foreground, the.dark { … }block) and the base rule:Each webview iframe gets the active theme class (e.g.
dark) added to its<body>by the webview host, but without the tailwind import these panels never defined the matching CSS variables or thebodybackground/text colors. So the empty-state text rendered with default colors instead of theme-aware ones — failing to respect dark mode.Fix
Add
@use './tailwind';to both panel stylesheets so they match the main editor and pick up the theme-awarebodystyling (and thetw:utilities). This covers the Model text, Bible texts, and Commentaries empty states.Testing
@use './tailwind';.platform-scripture-editor.web-view.scssin the same directory.AI-assisted — session
🤖 Generated with Claude Code
Generated by Claude Code
This change is