Skip to content

Fix putImage mutating the global filters array #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
douglasmatheus wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −2
Open

Fix putImage mutating the global filters array #3987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a417929
Fix putImage mutating the global filters array
douglasmatheus May 22, 2026
21187f0
Merge branch 'master' into fix/putimage-mutates-global-filters
douglasmatheus Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/modules/addimage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@ import { atob } from "../libs/AtobBtoa.js";
var putStream = this.internal.putStream;
var getFilters = this.internal.getFilters;

var filter = getFilters();
// getFilters() returns the live reference to the document-wide filters
// array. Copy it before mutating so we don't strip FlateEncode from
// subsequent output() calls (which would emit page content streams
// uncompressed after the first call to putImage).
var filter = getFilters().slice();
while (filter.indexOf("FlateEncode") !== -1) {
filter.splice(filter.indexOf("FlateEncode"), 1);
}
Expand Down
18 changes: 17 additions & 1 deletion test/specs/addimage.spec.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.