fix: cast also when building the attribute from the default#59
Open
HoneyryderChuck wants to merge 2 commits into
Open
fix: cast also when building the attribute from the default#59HoneyryderChuck wants to merge 2 commits into
HoneyryderChuck wants to merge 2 commits into
Conversation
HoneyryderChuck
force-pushed
the
cast-defaults
branch
3 times, most recently
from
6580bae to
38b7ee1
Compare
this enforces coercing in cases where the default is set up in a related-but-not-the-same type defined for the attribute. this is required to work correctly which gems which extend on the activemodel attributes API, such as `store_model`, where the default is recommended to be defined as a hash for cases where the attribute type is defined as a nested store model type.
HoneyryderChuck
force-pushed
the
cast-defaults
branch
from
38b7ee1 to
8cc37c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
this enforces coercing in cases where the default is set up in a related-but-not-the-same type defined for the attribute.
this is required to work correctly which gems which extend on the activemodel attributes API, such as
store_model, where the default is recommended to be defined as a hash for cases where the attribute type is defined as a nested store model type.What changes did you make? (overview)
The change is simply to apply the same
type.castoperation on the default value, same as when the value is set.Is there anything you'd like reviewers to focus on?
While the patch wasn't AI-generated, the tests were. They may be "overtesting", so perhaps I'd focus on "filler" tests which don't add much and could be removed.
Checklist