Skip to content

fix: grab correct version of flit-core when building tar file - #1071

Open
sgaist wants to merge 5 commits into
mainfrom
fix/grab-correct-flit-core-version
Open

fix: grab correct version of flit-core when building tar file#1071
sgaist wants to merge 5 commits into
mainfrom
fix/grab-correct-flit-core-version

Conversation

@sgaist

@sgaist sgaist commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The script currently grabs the latest version of flit-core
which at this time does not match the constraints set in the
pyproject.

Use the build-system requires entry to download a version that
matches the constraints.

Use Cases

Fix the compiled dependencies automated update job.
The job currently succeeds but creates an unusable tar ball.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

The script currently grabs the latest version of flit-core
which at this time does not match the constraints set in the
pyproject.

Use the build-system requires entry to download a version that
matches the constraints.
@sgaist
sgaist requested review from a team as code owners August 8, 2026 19:20
@sgaist sgaist added the semver:patch A change requiring a patch version bump label Aug 8, 2026
jericop
jericop previously approved these changes Aug 9, 2026

@jericop jericop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a fix, but should we have the script support installing all dependencies in the ["build-system"]["requires"] list rather than only [0]?

@sgaist

sgaist commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

I though about it but after reading https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ where most of the time you have only the build backend listed, I went for the simplest solution.

I don't mind adding support to manage a list of more than one dependency though.

- Move to the Paketo implementation of libdependency
- Fix go-license-detector to 4.3.0
@sgaist
sgaist force-pushed the fix/grab-correct-flit-core-version branch from 184da36 to 9ffac65 Compare August 9, 2026 19:13
@sgaist

sgaist commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@jericop I have implemented a version that will take all constraints in paketo-buildpacks/python-package-managers-install#289.
Tell me what you think about it and I will backport it here.

@jericop

jericop commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I have implemented a version that will take all constraints in paketo-buildpacks/python-package-managers-install#289.
Tell me what you think about it and I will backport it here.

That looks good to me. I'm happy with either approach after reading through the docs, but the latest approach should future-proof us if things change.

@sgaist
sgaist enabled auto-merge (squash) August 10, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A change requiring a patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants