fix: grab correct version of flit-core when building tar file - #1071
fix: grab correct version of flit-core when building tar file#1071sgaist wants to merge 5 commits into
Conversation
The script currently grabs the latest version of flit-core which at this time does not match the constraints set in the pyproject. Use the build-system requires entry to download a version that matches the constraints.
jericop
left a comment
There was a problem hiding this comment.
Approving as a fix, but should we have the script support installing all dependencies in the ["build-system"]["requires"] list rather than only [0]?
|
I though about it but after reading https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ where most of the time you have only the build backend listed, I went for the simplest solution. I don't mind adding support to manage a list of more than one dependency though. |
- Move to the Paketo implementation of libdependency - Fix go-license-detector to 4.3.0
184da36 to
9ffac65
Compare
|
@jericop I have implemented a version that will take all constraints in paketo-buildpacks/python-package-managers-install#289. |
That looks good to me. I'm happy with either approach after reading through the docs, but the latest approach should future-proof us if things change. |
Summary
The script currently grabs the latest version of flit-core
which at this time does not match the constraints set in the
pyproject.
Use the build-system requires entry to download a version that
matches the constraints.
Use Cases
Fix the compiled dependencies automated update job.
The job currently succeeds but creates an unusable tar ball.
Checklist