Minor performance improvements#4
Conversation
|
Actually I think custom for loop filter would be even faster.. Good changes, I'll check out these in the evening – thank you!! |
|
I haven't been updating this for a while, there's a whole lot more changes I'd make today so I check those out first.. 😉 |
|
@pakastin Yup custom for loop filter would be faster, and we can do a |
1 similar comment
|
@pakastin Yup custom for loop filter would be faster, and we can do a |
Small pull requests which makes minor performance improvements to the libraries
filterinstead of spliceRemoving the use of splice and for loop in
destroymethod with filter since it's more efficient and IMO more clearer though.Additional discussions:
I did not make a PR with that, since that's a big function and there's only one scenario (when animation ends) we need to make any mutations to the array, so doing a filter will make the code clunky, but this is something I would like to discuss further.
have a nice day. thanks for this library