Feature/aptly error handling#3
Open
embtom wants to merge 8 commits into
Open
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the local test build scripts and the Python tooling to improve robustness around Aptly interactions and to support a two-phase “build then upload” workflow (via a new --no-build flag).
Changes:
- Refactors
test/*/build.shscripts to share Podman arguments and to supportbuild|upload|allactions (upload now runs with--no-build). - Improves Aptly client error handling and restructures upload/publish logic; CLI now has clearer failure behavior when build artifacts are missing.
- Removes the
prepare_envhelper script and updates local dev config (launch.json,.gitignore, credential template).
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/systemd/build.sh | Refactors Podman invocation; adds build/upload split via --no-build. |
| test/debhello/build.sh | Same refactor as systemd script; supports separate upload step. |
| test/aptly-credentials.user | Adds a checked-in credential template for local use. |
| packtly-builder/tooling/prepare_env | Removes the Poetry-based environment preparation script. |
| packtly-builder/tooling/packtly_builder_tooling/tests/test_debuild.py | Adjusts test scaffolding to match Debuild logging changes. |
| packtly-builder/tooling/packtly_builder_tooling/parts/debuild.py | Switches to a module-level logger rather than per-instance logger. |
| packtly-builder/tooling/packtly_builder_tooling/parts/aptly.py | Adds richer Aptly exception handling and new upload behavior (incl. force_upload). |
| packtly-builder/tooling/packtly_builder_tooling/cli.py | Introduces --no-build, refactors build into helper, improves missing-artifact error handling. |
| .vscode/launch.json | Updates debug args to use credentials file and --no-build. |
| .gitignore | Ignores aptly-credentials files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed8057f to
bdaafec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Added
Changed