Skip to content

Feature/aptly error handling#3

Open
embtom wants to merge 8 commits into
mainfrom
feature/aptly_error_handling
Open

Feature/aptly error handling#3
embtom wants to merge 8 commits into
mainfrom
feature/aptly_error_handling

Conversation

@embtom

@embtom embtom commented Jun 5, 2026

Copy link
Copy Markdown
Member

###Added

  • Dedicated aptly credentials support for authenticated publishing workflows

Changed

  • Build/test scripts were modularized to separate package build and upload phases
  • Aptly package build/upload flow was hardened with improved validation, logging, and failure handling

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1229 1014 83% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 8f29524 by action🐍

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the local test build scripts and the Python tooling to improve robustness around Aptly interactions and to support a two-phase “build then upload” workflow (via a new --no-build flag).

Changes:

  • Refactors test/*/build.sh scripts to share Podman arguments and to support build|upload|all actions (upload now runs with --no-build).
  • Improves Aptly client error handling and restructures upload/publish logic; CLI now has clearer failure behavior when build artifacts are missing.
  • Removes the prepare_env helper script and updates local dev config (launch.json, .gitignore, credential template).

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/systemd/build.sh Refactors Podman invocation; adds build/upload split via --no-build.
test/debhello/build.sh Same refactor as systemd script; supports separate upload step.
test/aptly-credentials.user Adds a checked-in credential template for local use.
packtly-builder/tooling/prepare_env Removes the Poetry-based environment preparation script.
packtly-builder/tooling/packtly_builder_tooling/tests/test_debuild.py Adjusts test scaffolding to match Debuild logging changes.
packtly-builder/tooling/packtly_builder_tooling/parts/debuild.py Switches to a module-level logger rather than per-instance logger.
packtly-builder/tooling/packtly_builder_tooling/parts/aptly.py Adds richer Aptly exception handling and new upload behavior (incl. force_upload).
packtly-builder/tooling/packtly_builder_tooling/cli.py Introduces --no-build, refactors build into helper, improves missing-artifact error handling.
.vscode/launch.json Updates debug args to use credentials file and --no-build.
.gitignore Ignores aptly-credentials files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/systemd/build.sh
Comment thread test/debhello/build.sh
Comment thread packtly-builder/tooling/packtly_builder_tooling/parts/aptly.py Outdated
Comment thread .vscode/launch.json
@embtom embtom force-pushed the feature/aptly_error_handling branch from ed8057f to bdaafec Compare June 6, 2026 09:27
@embtom embtom self-assigned this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants