Feature/complex deb package#2
Merged
Merged
Conversation
- Added support for logging to a file in the CLI. - Improved build dependency installation to handle virtual packages and architecture restrictions. - Updated build_dependencies method to aggregate dependencies from multiple fields. - Removed redundant assertion in test_deb_changes_arch.
embtom
commented
May 21, 2026
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Pull request overview
Adds support for building more complex Debian packages by improving build-dependency handling and Aptly connectivity in packtly_builder_tooling, plus a local Systemd build helper under Test/systemd/.
Changes:
- Switch build dependency installation to
mk-build-depsand adjustdebuildinvocation to build binaries only. - Add Aptly HTTP basic authentication parameters (
--username/--password) and--log-filesupport in the CLI. - Add local helper scripts for cloning/building Systemd in a container and update container env for noninteractive installs.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| Test/systemd/clone.sh | Adds a helper script to clone the upstream Systemd repo into the test directory. |
| Test/systemd/build.sh | Adds a helper script to run the builder container against the Systemd repo and upload artifacts. |
| Test/systemd/.gitignore | Ignores the cloned Systemd tree and generated .deb artifacts. |
| packtly-builder/tooling/packtly_builder_tooling/tests/test_debuild.py | Adjusts architecture assertion to match the new binary-only build behavior. |
| packtly-builder/tooling/packtly_builder_tooling/parts/debuild.py | Adds mk-build-deps-based dependency installation and streams debuild output. |
| packtly-builder/tooling/packtly_builder_tooling/parts/aptly.py | Adds configurable HTTP basic auth and tweaks host logging. |
| packtly-builder/tooling/packtly_builder_tooling/parts/apt.py | Improves dependency-string parsing for profiles/arch restrictions and attempts virtual package resolution. |
| packtly-builder/tooling/packtly_builder_tooling/cli.py | Adds --username/--password and --log-file, changes signing keyring location, and uses install_build_dependencies(). |
| packtly-builder/containers/Containerfile | Sets DEBIAN_FRONTEND=noninteractive for container installs. |
| CHANGELOG.md | Documents the new CLI args and dependency handling changes in the 1.1.0 entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
embtom
force-pushed
the
feature/complex_deb_package
branch
from
77ef4c4 to
15074ff
Compare
embtom
force-pushed
the
feature/complex_deb_package
branch
from
d702133 to
036d734
Compare
embtom
force-pushed
the
feature/complex_deb_package
branch
from
84f0c4e to
57de115
Compare
embtom
force-pushed
the
feature/complex_deb_package
branch
from
57de115 to
a4998b2
Compare
embtom
force-pushed
the
feature/complex_deb_package
branch
from
f9a76f5 to
86346f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PROFILE_REregex compilation from insideinstall_package()to module scope to avoid repeated compilation overhead