Skip to content

codegen: use command -v instead of fragile which + \$? pattern #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispsommers merged 1 commit into from
Jul 10, 2026
Merged

codegen: use command -v instead of fragile which + \$? pattern #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions codegen/compile_protos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,17 @@ if [ "$#" -ne 1 ]; then
fi

BUILD_DIR="$1"
PROTOC="$(which protoc)"
if [ "$?" -ne 0 ]; then
echo "Could not find protoc"
exit 2
fi

command -v protoc >/dev/null 2>&1 || { echo "Could not find protoc"; exit 2; }
PROTOC="$(command -v protoc)"

echo "Using $PROTOC"

GRPC_CPP_PLUGIN="$(which grpc_cpp_plugin)"
if [ "$?" -ne 0 ]; then
echo "Could not find CPP protoc plugin"
exit 2
fi
GRPC_PY_PLUGIN="$(which grpc_python_plugin)"
if [ "$?" -ne 0 ]; then
echo "Could not find Python protoc plugin"
exit 2
fi
command -v grpc_cpp_plugin >/dev/null 2>&1 || { echo "Could not find CPP protoc plugin"; exit 2; }
GRPC_CPP_PLUGIN="$(command -v grpc_cpp_plugin)"

command -v grpc_python_plugin >/dev/null 2>&1 || { echo "Could not find Python protoc plugin"; exit 2; }
GRPC_PY_PLUGIN="$(command -v grpc_python_plugin)"

set -e

Expand Down
Loading