Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Add support for Github enterprise repositories - #20

Closed
d1egoaz wants to merge 1 commit into
ozanvos:masterfrom
d1egoaz:add_suport_github_enterprise_repositories
Closed

Add support for Github enterprise repositories#20
d1egoaz wants to merge 1 commit into
ozanvos:masterfrom
d1egoaz:add_suport_github_enterprise_repositories

Conversation

@d1egoaz

@d1egoaz d1egoaz commented Feb 26, 2016

Copy link
Copy Markdown

Add support for Github enterprise repositories as hostnames are different than github.com.

This is my first time writing LISP code, so I hope I'm not doing something crazy here.

@diego-alvarez-hs

Copy link
Copy Markdown

Ping @osener

@ozanvos

ozanvos commented Mar 24, 2016

Copy link
Copy Markdown
Owner

@diego-alvarez-hs sorry for taking so long to review this. I see you're taking the full url from remote.origin.url but I think more often than not non-github values will point to something like Bitbucket rather than a Github Enterprise repo.

What do you think about introducing a local variable such as github-browse-file--github-enterprise-root and using it instead of github.com if it's non-nil?

/cc @dgtized, @wjlroe, and @waymondo as you guys are probably more familiar with this package than I am at this point, and hopefully have experience with Github Enterprise :)

@d12frosted

Copy link
Copy Markdown

Also, relying on remote.origin.url is not really good, because origin is optional name.

slackorama pushed a commit to slackorama/github-browse-file that referenced this pull request Nov 23, 2016
@slackorama

Copy link
Copy Markdown

I took a stab at adding support for github enterprise and bitbucket...as well as the non-origin remotes.

@jjrussell

Copy link
Copy Markdown

I think I just wrote almost the same thing. Should have checked for existing PRs I guess #facepalm
#26

@d1egoaz d1egoaz closed this Nov 30, 2020
@d1egoaz
d1egoaz deleted the add_suport_github_enterprise_repositories branch November 30, 2020 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants