Always use @ local rather than local_ syntax in types#142
Merged
Conversation
nmatschke
force-pushed
the
nmatschke.always-print-at-local-in-types
branch
from
357976b to
d2f9b44
Compare
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
dvulakh
approved these changes
May 20, 2026
dvulakh
left a comment
dvulakh
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the requested changes.
I was surprised that there were no changes needed to the std ast normalization pass, but it seems local_ and @ local do indeed parse the same even in ocamlformat's stdast.
In case you haven't seen it:
dune exec tools/printast/printast.exe --
is a handy tool for inspecting the behavior of ocamlformat's parsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ocamlformat print
T @ localrather thanlocal_ T, even if the user wrote the latter.We insert
localin sorted order amongst the other modes.This was 100% written by claude.