Support kind declarations#140
Merged
Merged
Conversation
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
ccasin
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for kind declarations/abstract kinds. It's based on #139.
parser-standardwas updated with the current syntax for these in #139, and the formatter already had support for the old, never-implementedkind_abbrevsyntax. So, this is mostly just renaming things and minor tweaks. Kind declaration formatting is replaced with a new version based on type declarations, which adds support for attributes and generalizes things so the same formatter can be used for signaturewith kind_substitutions (support for which is also added).The old
kind_abbrevation.mltest, deleted in the previous PR, is brought back asabstract_kinds.ml. I had a robot delete the with kinds from it, as there is a new restriction (from the compiler) that with kinds are now allowed in kind manifests. The test is also enhanced to include fully abstract kind declarations and attributes. There is a new test for the signature-levelwith kind_substitutions.Doc comments are missing from all tests, because support for them is busted on the compiler side. I've posted oxcaml/oxcaml#5987 to remedy that, and will import that support here later as a separate PR with its own tests.