Skip to content

Implemented support for audio playback with 'canPlayType' webAPI feature#950

Open
chiarorosa wants to merge 2 commits into
owncloud:masterfrom
chiarorosa:master
Open

Implemented support for audio playback with 'canPlayType' webAPI feature#950
chiarorosa wants to merge 2 commits into
owncloud:masterfrom
chiarorosa:master

Conversation

@chiarorosa

Copy link
Copy Markdown

Implemented support for audio playback with 'canPlayType' webAPI feature, updated config.json mimetypes

@CLAassistant

CLAassistant commented Nov 1, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@chiarorosa

Copy link
Copy Markdown
Author

Waiting for a reviewer's approval 😉

@dj4oC dj4oC left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Security: no findings — no \OC\ private API usage, no new dependency, no injection surface (mimetype string matching only).
  • Stability: functional change is small and sound — extends the video-only canPlayType mimetype-registration check to also probe <audio> elements via a broadened /^(audio|video)/ regex, and adds audio/mpeg/audio/wav to the registered mimetypes. Logic reads correctly for the stated goal (audio playback support).
  • Performance: no findings
  • Test coverage: no JS tests exist in this app (confirmed elsewhere in this repo, e.g. #1132/#1133), so this is consistent with existing project practice, not a regression in coverage.
  • TODOs found: 0
  • Dependency touched: no
  • CI status: no checks recorded for this PR (open since Nov 2023, predates current Actions CI)
  • Note: roughly half the diff in init.js is unrelated formatting/style churn (semicolon removal, quote style) mixed into the same commit as the functional change — makes the real diff harder to review. Would be cleaner split into a separate formatting-only commit/PR.

Verdict

Functionally reasonable, low-risk feature addition; author has been waiting for a reviewer since Nov 2023. Recommend a maintainer rebase/re-trigger CI and merge if webUI playback is manually verified — the mixed style-churn diff is a minor nit, not a blocker.

🤖 Automated review by Claude Code (security · stability · performance · coverage)


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants