Refactoring/making similarity consistent#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces proper naming for the variables. In 99% of cases the
cost matrixis changed to thesimilarity matrixto avoid confusion. The bigger the similarity the more similar the images are, the bigger the costs the more dissimilar the images are. Thecostsare only used in theonline_localizerbecause they are used in the graph search. Everything else works on similarity values/scores.This PR also breaks the compatibility with previously processed data because it renames the proto message from
CostMatrixtoSimilarityMatrix. The solution is to recompute the datasets starting frompython run_matching_from_images.py ...