fix: Fixed cache entries never being cleaned#629
Open
DrRebus wants to merge 1 commit into
Open
Conversation
DrRebus
requested review from
loopfz,
rbeuque74,
rclsilver and
wI2L
as code owners
DrRebus
force-pushed
the
rtordjma/fix-cache-cleanup
branch
2 times, most recently
from
cef80e2 to
5caa03b
Compare
Signed-off-by: Ruben Tordjman <144785435+DrRebus@users.noreply.github.com>
DrRebus
force-pushed
the
rtordjma/fix-cache-cleanup
branch
from
5caa03b to
cad35c3
Compare
rclsilver
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
In the the new
cacheplugins, expired entries are supposed to be cleaned at startup, but the initializer plugin is ran before the DB is set up, meaning that the plugin can't perform the cleanup and fails silently.What is the new behavior (if this is a feature change)?
The cleaning of expired entries is moved to a new collector running every 24h and at startup, once the database is properly initialized.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking change.
Other information:
Link to the guilty code: https://github.com/ovh/utask/blob/master/pkg/plugins/builtin/cache/init.go#L26