Skip to content

Fixes email subject line #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scotthasbrouck wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes email subject line #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Overshare Kit/OSKShareableContent.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ + (instancetype)contentFromMicroblogPost:(NSString *)text authorName:(NSString *

content.title = [NSString stringWithFormat:@"Post by %@: “%@”", authorName, text];

NSString *appName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];

NSURL *URLforCanonicalURL = nil;
if (canonicalURL) {
URLforCanonicalURL = [NSURL URLWithString:canonicalURL];
Expand Down Expand Up @@ -166,7 +168,7 @@ + (instancetype)contentFromMicroblogPost:(NSString *)text authorName:(NSString *

OSKEmailContentItem *emailItem = [[OSKEmailContentItem alloc] init];
emailItem.body = [NSString stringWithFormat:@"“%@”\n\n(Via @%@)\n\n%@ ", text, authorName, canonicalURL];
emailItem.subject = @"Clipper Ships Sail On the Ocean";
emailItem.subject = [NSString stringWithFormat:@"Link from %@", appName];
emailItem.attachments = images.copy;
content.emailItem = emailItem;

Expand All @@ -185,7 +187,6 @@ + (instancetype)contentFromMicroblogPost:(NSString *)text authorName:(NSString *
OSKLinkBookmarkContentItem *linkBookmarking = [[OSKLinkBookmarkContentItem alloc] init];
linkBookmarking.url = URLforCanonicalURL;
linkBookmarking.notes = [NSString stringWithFormat:@"%@\n\n%@", text, canonicalURL];
NSString *appName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];
linkBookmarking.tags = @[appName];
linkBookmarking.markToRead = YES;
content.linkBookmarkItem = linkBookmarking;
Expand Down