init: fix fork_prepare lock order for heap_main.arena_pages_lock#4
Open
dylan-conway wants to merge 1 commit into
Open
init: fix fork_prepare lock order for heap_main.arena_pages_lock#4dylan-conway wants to merge 1 commit into
dylan-conway wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_mi_process_fork_preparetakesheap_main.arena_pages_lockbefore per-heaph->arena_pages_lock. At runtime the order is the opposite: a non-main heap'smi_heap_ensure_arena_pagesholdsh->arena_pages_lockand callsmi_heap_zalloc_aligned(mi_heap_main(), ...)(arena.c:672→682→1498→778), which can recurse intoheap_main->arena_pages_lock. AB-BA with a thread mid-first-touch whenfork()is called.Moved
heap_main.arena_pages_lockto after the per-heap loop (the original placement comment was wrong —mi_heap_ensure_arena_pagesshort-circuits for heap_main at arena.c:675 and never allocates)._mi_process_fork_parentrelease order updated symmetrically.