Skip to content

ESP32-S3: adjust board pin mappings and make encoder optional in UI #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ovelhaaa wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ESP32-S3: adjust board pin mappings and make encoder optional in UI #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3362870
Make encoder optional during UI init and tick
ovelhaaa Apr 29, 2026
87ff76e
Gate encoder by board presence flag and move TFT backlight pin
ovelhaaa Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions targets/embedded_esp32s3/main/board_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ constexpr uint16_t kHeight = 135;
namespace spi {
constexpr int kMosiGpio = 35;
constexpr int kSclkGpio = 36;
constexpr int kCsGpio = 37;
constexpr int kCsGpio = 7;
} // namespace spi

constexpr int kDcGpio = 38;
constexpr int kResetGpio = 39;
constexpr int kBacklightGpio = 40;
constexpr int kDcGpio = 39;
constexpr int kResetGpio = 40;
constexpr int kBacklightGpio = 38;
} // namespace tft

namespace encoder {
Expand All @@ -45,10 +45,11 @@ namespace encoder {
constexpr int kA = 14;
constexpr int kB = 15;
constexpr int kSwitch = 16;
constexpr bool kPresent = false; // Set true on board revisions with populated rotary encoder.
} // namespace encoder

namespace controls {
constexpr int kBypassButton = 5;
constexpr int kBypassButton = 9;
} // namespace controls

// Guard against accidental overlap with active audio I2S signals.
Expand Down
18 changes: 13 additions & 5 deletions targets/embedded_esp32s3/main/ui_app.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,13 @@ class UserInterface {
bool init(uint8_t* framebuffer) {
if (!display_.init(framebuffer)) return false;

if (!encoder_.init()) return false;
enc_btn_.init();
encoder_available_ = board::encoder::kPresent;
if (encoder_available_) {
encoder_available_ = encoder_.init();
if (encoder_available_) {
enc_btn_.init();
}
}
bypass_btn_.init();

// Initialize parameters matching the requested grid layout
Expand All @@ -53,7 +58,9 @@ class UserInterface {
}

void tick(ParameterBridge& bridge) {
enc_btn_.update();
if (encoder_available_) {
enc_btn_.update();
}
bypass_btn_.update();

if (bypass_btn_.justPressed()) {
Expand All @@ -63,13 +70,13 @@ class UserInterface {
display_.update();
}

if (enc_btn_.justPressed()) {
if (encoder_available_ && enc_btn_.justPressed()) {
mode_ = (mode_ == UiMode::Scroll) ? UiMode::Edit : UiMode::Scroll;
drawUI();
display_.update();
}

int delta = encoder_.getDelta();
int delta = encoder_available_ ? encoder_.getDelta() : 0;
if (delta != 0) {
if (mode_ == UiMode::Scroll) {
selected_idx_ += delta;
Expand Down Expand Up @@ -244,6 +251,7 @@ class UserInterface {
int selected_idx_ = 0;
UiMode mode_ = UiMode::Scroll;
bool bypassed_ = false;
bool encoder_available_ = false;
};

} // namespace orbit::embedded::ui