Skip to content

fix(nav): prevent workspace card diff overlap#129

Merged
ovdmar merged 2 commits into
mainfrom
fb-nav-pr-diff-overlap
Jun 8, 2026
Merged

fix(nav): prevent workspace card diff overlap#129
ovdmar merged 2 commits into
mainfrom
fb-nav-pr-diff-overlap

Conversation

@ovdmar

@ovdmar ovdmar commented Jun 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Reserve the full right-control lane on workspace cards so PR diff totals do not render under the structured workspace + / collapse controls.
  • Add a Vitest regression guard for the CSS lane sizing contract.

Plan

Inline / trivial

Test plan

  • make check passes locally
  • pnpm e2e passes locally
  • pnpm smoke: not run; daemon HTTP surface unchanged

How to QA

  1. Pull the branch: git checkout fb-nav-pr-diff-overlap
  2. Install: pnpm install
  3. Full check: make check
  4. Start the daemon + web in dev mode: pnpm dev
  5. Open a structured workspace row that shows PR diff totals and the add-worktree + control; verify the + remains clear of the +added/-deleted totals.
  6. Hover/focus the workspace row and verify the right-side controls remain clickable without covering the diff totals.

For E2E coverage:

  • pnpm e2e to run the full suite

@ovdmar ovdmar merged commit 79cbcdc into main Jun 8, 2026
8 checks passed
@ovdmar ovdmar deleted the fb-nav-pr-diff-overlap branch June 8, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant