Skip to content

Default shell terminals to PTY daemon#123

Merged
ovdmar merged 2 commits into
mainfrom
wily-heron
Jun 7, 2026
Merged

Default shell terminals to PTY daemon#123
ovdmar merged 2 commits into
mainfrom
wily-heron

Conversation

@ovdmar

@ovdmar ovdmar commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • default new plain shell terminal sessions to the PTY daemon backend instead of tmux
  • keep legacy tmux creation behind CITADEL_TERMINAL_BACKEND=tmux and preserve existing persisted tmux rows
  • add best-effort PTY owner cleanup when stopping PTY-daemon sessions

Verification

  • pnpm typecheck
  • pnpm lint
  • pnpm check:arch
  • pnpm check:size
  • pnpm check:deps
  • pnpm build
  • pnpm vitest run packages/terminal/src/pty-daemon-client.test.ts packages/terminal/src/pty-daemon-websocket.test.ts
  • Earlier targeted operations test passed before the local full-suite Vitest workers entered an unrelated disk-I/O wait. A later rerun under timeout produced no assertion output before timing out, consistent with that local stall.

Scope note

This moves the supported plain shell Terminal path. Agent sessions still use the tmux-specific launch/status/message helpers and need a separate backend-adapter migration before they can become PTY-daemon-backed.

@ovdmar ovdmar merged commit 2310846 into main Jun 7, 2026
8 checks passed
@ovdmar ovdmar deleted the wily-heron branch June 7, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant