Skip to content

fix(daemon): stabilize checkout pr cache keys#122

Merged
ovdmar merged 1 commit into
mainfrom
fb-checkout-pr-cache-key
Jun 7, 2026
Merged

fix(daemon): stabilize checkout pr cache keys#122
ovdmar merged 1 commit into
mainfrom
fb-checkout-pr-cache-key

Conversation

@ovdmar

@ovdmar ovdmar commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stabilize checkout PR cache keys so PR cards remain visible after PR binding updates bump workspace_checkouts.updated_at.
  • Stop structured root workspaces from spending GitHub VC/CI refreshes while still refreshing checkout children.
  • Enter GitHub cooldown at 99% used for core/graphql quota, before the remaining quota reaches zero.

Plan

Inline / trivial

Test plan

  • pnpm vitest run apps/daemon/src/workspaces-pr-state-route.test.ts apps/daemon/src/provider-refresh-job.test.ts apps/daemon/src/github-provider-state.test.ts apps/daemon/src/checkout-pr-primer.test.ts apps/daemon/src/app-github-quota.test.ts
  • pnpm lint
  • pnpm typecheck
  • pnpm check:size
  • make check passes locally
  • Manual QA per the How-to-QA section below

How to QA

  1. Pull the branch: git checkout fb-checkout-pr-cache-key
  2. Install: pnpm install
  3. Full check: make check
  4. Start the daemon + web in dev mode: pnpm dev
  • Open the cockpit stats right panel for a structured workspace checkout that has an associated PR, and verify the PR card is visible.
  • Trigger or wait for a checkout PR binding refresh, then refresh /api/workspaces/pr-state and verify the same checkout PR summary is still present.
  • Exercise /api/integrations/github/quota with a near-exhausted core/graphql quota and verify provider polling enters cooldown before quota reaches zero.

@ovdmar ovdmar merged commit 7cc43eb into main Jun 7, 2026
8 of 16 checks passed
@ovdmar ovdmar deleted the fb-checkout-pr-cache-key branch June 7, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant