refactor(core): convert edit.ts to Result returns

[galligan]

Replace all 11 throw statements in editWaymark() and its internal
helpers with typed Result returns using ValidationError, NotFoundError,
and InternalError from @outfitter/contracts.

• editWaymark() now returns Promise<WaymarkResult>
• Zod .parse() replaced with .safeParse() to avoid exceptions
• resolveTarget, resolveRecordContext, assertIdMatches, resolveType,
  resolveUpdatedRecord, updateIdIndex all return WaymarkResult
• Split editWaymark into resolveEditContext + applyEdit to stay
  under cognitive complexity limit of 15
• Tests updated to unwrap Results via .isOk()/.value
• Added 2 new error-path tests (missing file, invalid spec)
• Fixed stale @outfitter/contracts@0.2.0 in core workspace

WAY-106

Greptile Summary

Successfully converted editWaymark() from exception-based to Result-based error handling. All 11 throw statements replaced with typed errors (ValidationError, NotFoundError, InternalError).

Key changes:

• Split editWaymark into resolveEditContext + applyEdit to maintain cognitive complexity under 15
• Replaced Zod .parse() with .safeParse() to avoid exceptions
• Updated return signature to Promise<WaymarkResult<EditResult>>
• All internal helpers (resolveTarget, resolveRecordContext, assertIdMatches, resolveType, resolveUpdatedRecord, updateIdIndex) now return WaymarkResult
• Updated @outfitter/contracts from 0.2.0 to 0.4.1
• Tests updated with proper Result unwrapping via .isOk() checks
• Added error-path coverage for missing files and invalid specs

Confidence Score: 5/5

• This PR is safe to merge with no issues found
• The refactor is systematic and complete with no logic changes. All error paths properly typed, test coverage updated appropriately, and the split of editWaymark maintains the same behavior while improving maintainability.
• No files require special attention

Important Files Changed

Filename	Overview
packages/core/src/edit.ts	Converted 11 throw statements to Result returns with proper error types. Split editWaymark into resolveEditContext and applyEdit to stay under complexity limit. All error paths properly typed.
packages/core/src/edit.test.ts	Updated all tests to unwrap Results via .isOk()/.value pattern. Added 2 new error-path tests for missing file and invalid spec. All tests properly handle the new Result return type.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[editWaymark] --> B[resolveEditContext]
    B --> C{safeParse EditSpec}
    C -->|Error| D[Return ValidationError]
    C -->|Success| E[resolveTarget]
    E -->|Error| D
    E -->|Success| F[loadFileSnapshot]
    F -->|Not Found| G[Return NotFoundError]
    F -->|Success| H[resolveRecordContext]
    H -->|Error| G
    H -->|Success| I[assertIdMatches]
    I -->|Error| D
    I -->|Success| J[resolveType]
    J -->|Error| D
    J -->|Success| K[Return EditContext]
    
    A --> L[applyEdit]
    K --> L
    L --> M[buildDraftLines]
    M --> N[applyDraftEdits]
    N --> O[resolveUpdatedRecord]
    O -->|Error| P[Return InternalError]
    O -->|Success| Q{ID exists?}
    Q -->|Yes| R[updateIdIndex]
    Q -->|No| S[Return EditResult]
    R -->|Error| P
    R -->|Success| S

Loading

_{Last reviewed commit: 8eb153a}

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor(mcp): convert handlers to Result-based error handling #282
• refactor(cli): convert modify.ts and add.ts to typed error flow #281
• refactor(core): convert edit.ts to Result returns #280 👈 (View in Graphite)
• refactor(cli): simplify output format handling in renderRecords #279
• feat(cli): adopt flag presets for shared CLI options #278
• feat(cli): adopt createCLI() for program bootstrap #277
• chore(deps): bump @outfitter/* packages to latest #276
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.