feat(trails): declare native bun release binding#714
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Merge activity
|
## Context Part of the Release Rules M3 follow-through for TRL-938. This branch declares the Trails-owned Bun release path as a native release binding instead of leaving publish and registry behavior in root scripts. ## What Changed - Added release binding descriptors for native and adapter release bindings. - Promoted the Bun publish and registry preflight implementation into `@ontrails/trails/release`. - Kept the existing root scripts as thin compatibility wrappers around the package-owned implementation. - Added focused release binding coverage and a branch-local changeset for `@ontrails/trails`. ## Verification - Focused release binding, release smoke, MCP, publish, and registry tests passed. - `bun run check` - `bun run test` - `bun run build` - `bun run wayfinder:dogfood` - `bun run dogfood:packed` - `bun run publish:check` - `gt submit --stack --draft --restack --no-edit --no-interactive --dry-run` - Real Graphite submit pre-push passed: dead-code, format, lint, ast-grep, test, typecheck, Warden. Known Warden warnings are the existing internal `wayfind.*` reachability warnings.
graphite-app
Bot
force-pushed
the
trl-938-make-release-publishemit-a-declared-seam-native-bun-binding
branch
from
3eb63f4 to
fd676c4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3eb63f412e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { tmpdir } from 'node:os'; | ||
| import { join, relative, resolve } from 'node:path'; | ||
|
|
||
| const REPO_ROOT = resolve(process.cwd()); |
There was a problem hiding this comment.
When the publish wrapper is invoked from anywhere other than the repository root (for example cd apps/trails && bun ../../scripts/publish.ts --check or an absolute path from CI), this now treats the current directory as the repo root and looks for package.json/.changeset there. The old script used its own location to anchor the root, so this promotion makes the compatibility entry point fail or inspect the wrong workspace set unless callers happen to cd to the root first.
Useful? React with 👍 / 👎.
graphite-app
Bot
deleted the
trl-938-make-release-publishemit-a-declared-seam-native-bun-binding
branch
1 participant
Context
Part of the Release Rules M3 follow-through for TRL-938.
This branch declares the Trails-owned Bun release path as a native release binding instead of leaving publish and registry behavior in root scripts.
What Changed
@ontrails/trails/release.@ontrails/trails.Verification
bun run checkbun run testbun run buildbun run wayfinder:dogfoodbun run dogfood:packedbun run publish:checkgt submit --stack --draft --restack --no-edit --no-interactive --dry-runKnown Warden warnings are the existing internal
wayfind.*reachability warnings.