chore(deps): bump criterion from 0.7.0 to 0.8.1#468
Conversation
dependabot
Bot
added
dependencies
|
Skipped: This PR was opened by one of your excluded authors: ( |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c178fc2f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # Performance & profiling | ||
| criterion = { version = "0.7", features = ["async_tokio"] } | ||
| criterion = { version = "0.8", features = ["async_tokio"] } |
There was a problem hiding this comment.
The workspace declares rust-version = "1.85.0" (Cargo.toml:16), but this change bumps criterion to 0.8 (Cargo.toml:48), whose upstream release notes state an MSRV of 1.86. That means any MSRV build or CI pinned to 1.85 will fail when resolving dev-dependencies (benches/tests), even if production code compiles, which breaks the documented MSRV contract. Either raise the workspace rust-version or keep criterion on 0.7 to maintain compatibility.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/criterion-0.8.1
branch
2 times, most recently
from
f1c956a to
b17969c
Compare
|
@dependabot rebase |
Bumps [criterion](https://github.com/criterion-rs/criterion.rs) from 0.7.0 to 0.8.1. - [Release notes](https://github.com/criterion-rs/criterion.rs/releases) - [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md) - [Commits](criterion-rs/criterion.rs@criterion-plot-v0.7.0...criterion-v0.8.1) --- updated-dependencies: - dependency-name: criterion dependency-version: 0.8.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/criterion-0.8.1
branch
from
b17969c to
9c082cd
Compare
1 participant
Bumps criterion from 0.7.0 to 0.8.1.
Release notes
Sourced from criterion's releases.
Changelog
Sourced from criterion's changelog.
Commits
e4e06dfchore: release v0.8.1aa548b9fix: Homepage link950c3b7fix: Typo7e3e50cchore(deps): bump crate-ci/typos from 1.23.5 to 1.40.0391a99achore(deps): bump jontze/action-mdbook from 3 to 48fb9a87chore(deps): bump actions/checkout from 4 to 6b49ade7chore: release v0.8.0You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)