node-18-update#59
Open
patpluspun wants to merge 49 commits into
Open
Conversation
digitalsadhu
left a comment
digitalsadhu
left a comment
Contributor
There was a problem hiding this comment.
Looks like the test command needs a tweak to from —no-cov to — —no-cov
Contributor
Author
Now the tests pass, but it exits with an error code and still doesn't "pass" :) |
Contributor
|
This is an issue with Tap v18. Just ran into it at work as well and had to downgrade to v16 to solve. |
…rrors imgur is returning.
This reverts commit 991e9a7.
patpluspun
force-pushed
the
development
branch
from
5e622e7 to
01fd9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is how the map will look now, using a sans-serif font and with added bottom and right axis. All tests should be passing too.