fix: add PR title lint workflow#191
Merged
Merged
Conversation
Enforce conventional commit PR titles via ossprey/cicd/pr-lint on opened, edited and reopened pull request events. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126vwoz9uFAw2GHZWNABAWX
ejevon
changed the title
dreadn0ught
requested changes
Jul 10, 2026
| permissions: | ||
| pull-requests: read | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v5 |
Contributor
There was a problem hiding this comment.
Can we instead not use external GH actions and give them our GH token, it's a bit of a security risk :/
Contributor
Author
There was a problem hiding this comment.
Good call. Dropped the external amannn/action-semantic-pull-request action entirely so no third party gets GITHUB_TOKEN. The title lint is now an inline shell check reading github.event.pull_request.title from the event payload (the action only needed the token to fetch what's already there). Title is passed via an env var rather than interpolated into the script to avoid shell injection, and permissions is now {} since no API access is needed.
Generated by Claude Code
Replace the third-party amannn/action-semantic-pull-request@v5 action,
which was handed secrets.GITHUB_TOKEN, with an inline shell check that
validates the PR title against Conventional Commits using the event
payload. This addresses the review concern about exposing our GitHub
token to an external action.
- No external action and no token are used; the PR title is read from
github.event.pull_request.title.
- The title is passed via an env var (not interpolated into the script)
to avoid shell injection.
- permissions is set to {} since no API access is required.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KtGBySiTPMbsJKPYb7zYYj
dreadn0ught
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds
.github/workflows/pr-lint.yml, which enforces conventional commit PR titles using the sharedossprey/cicd/pr-lint@mainaction on opened, edited and reopened pull request events. This matches the existing setup in the ossprey and dashboard repos and is part of an org wide rollout.Notes
The check only gates merges once
lint-titleis added as a required status check in branch protection. No runtime code is affected.🤖 Generated with Claude Code
https://claude.ai/code/session_0126vwoz9uFAw2GHZWNABAWX
Generated by Claude Code