Generate codecov-result.json for CI#2855
Merged
Merged
Conversation
Codecov uploads were failing with "Found 0 coverage files to report" because coverage/codecov-result.json was never written. The test workers run with DEFER_COVERAGE set, which swaps in the minimal SimpleFormatter, so SimpleCov::Formatter::Codecov never runs during the test processes. The finalize task test:coverage_gaps merged the results but never invoked the Codecov formatter, so no file existed for the pinned CLI to upload. This commit modifies the test process so, when running in CI, we write coverage/codecov-result.json from the merged result in test:coverage_gaps. We call the gem's inner Codecov::SimpleCov::Formatter directly rather than SimpleCov::Formatter::Codecov, since the latter also invokes the gem's deprecated built-in network uploader; we upload separately with a pinned, hash-verified CLI and want only the file-writing half. Co-Authored-By: David A. Wheeler <dwheeler@dwheeler.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov uploads were failing with "Found 0 coverage files to report" because coverage/codecov-result.json was never written. The test workers run with DEFER_COVERAGE set, which swaps in the minimal SimpleFormatter, so SimpleCov::Formatter::Codecov never runs during the test processes. The finalize task test:coverage_gaps merged the results but never invoked the Codecov formatter, so no file existed for the pinned CLI to upload.
This commit modifies the test process so, when running in CI, we write coverage/codecov-result.json from the merged result in test:coverage_gaps. We call the gem's inner
Codecov::SimpleCov::Formatter directly rather than SimpleCov::Formatter::Codecov, since the latter also invokes the gem's deprecated built-in network uploader; we upload separately with a pinned, hash-verified CLI and want only the file-writing half.