Skip to content

OSAC-1675: Add e2e-full-install required check to osac-installer#114

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:OSAC-1675-installer-e2e-required-check
Jun 26, 2026
Merged

OSAC-1675: Add e2e-full-install required check to osac-installer#114
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:OSAC-1675-installer-e2e-required-check

Conversation

@eliorerz

@eliorerz eliorerz commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds e2e-full-install / e2e as a required status check for the osac-installer repo
  • Adds the e2e-test GitHub environment (needed by the reusable workflow)

Context

Summary by CodeRabbit

  • New Features
    • Added extra merge requirements so changes must pass an end-to-end install check before approval.
    • Enabled an additional testing environment for safer validation of updates.

Add the E2E full install job as a required status check and configure
the e2e-test GitHub environment for the osac-installer repository.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 82df167e-0cfd-4f8f-b558-45cd48192769

📥 Commits

Reviewing files that changed from the base of the PR and between c1cbb63 and dfdeaf9.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

repo_osac_installer in repositories.tf now includes an e2e-full-install / e2e required status check and an e2e-test environment entry.

Changes

E2E gate configuration

Layer / File(s) Summary
Repo gate settings
repositories.tf
The repo_osac_installer module adds the e2e-full-install / e2e status check and associates the module with the e2e-test environment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • osac-project/github-config#108: Touches the same repo_osac_installer block in repositories.tf and changes the required_status_checks configuration there.

Poem

A gate was tuned, a check was set,
For e2e paths to meet the net.
e2e-test stands in the light,
While installer rules hold tight.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the e2e-full-install required check to osac-installer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed repositories.tf only adds a status check and environment name; no hardcoded secrets, tokens, passwords, keys, or credentialed URLs were found.
No-Weak-Crypto ✅ Passed PASS: The commit only updates repo config, and a scan of all commit blobs found no MD5/SHA1/DES/RC4/ECB/etc. or secret/token comparisons.
No-Injection-Vectors ✅ Passed Only static Terraform config changed; repo scan found no SQL/shell/eval/yaml/pickle/HTML injection sinks.
Container-Privileges ✅ Passed Only repositories.tf changed; it adds GitHub repo protection settings, not container/K8s manifests, and no privilege flags are present.
No-Sensitive-Data-In-Logs ✅ Passed Only Terraform branch-protection/env config was added; no logging statements or sensitive data exposure found in the changed file.
Ai-Attribution ✅ Passed No AI-tool use is mentioned in the PR or commit, and the commit has no AI attribution trailers to verify.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eliorerz eliorerz merged commit b7abe32 into osac-project:main Jun 26, 2026
1 of 2 checks passed
@eliorerz eliorerz deleted the OSAC-1675-installer-e2e-required-check branch June 26, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant