Bug fix hazard string to class#601
Open
jroman-ak wants to merge 1 commit into
Open
Conversation
jroman-ak
force-pushed
the
contribute-bug-fix
branch
3 times, most recently
from
ca09586 to
b5b4659
Compare
YulianLC
force-pushed
the
contribute-bug-fix
branch
2 times, most recently
from
89bbd27 to
448cee3
Compare
jroman-ak
force-pushed
the
contribute-bug-fix
branch
from
448cee3 to
e5826a6
Compare
Signed-off-by: Yulian Lyubomirov Cenov <ycenov@arfima.com>
YulianLC
force-pushed
the
contribute-bug-fix
branch
from
e5826a6 to
600a61b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix a bug in
InventorySourcePaths.hazard_types. Previously it would attempt conversion from a hazard string to a hazard class without guards. This failed if the inventory contained a hazard that was not registered as a Hazard class in physrisk. Now it simply skips that hazard and logs a warning.We also remove a module in the tests that is unused after the recent migration to pytest.
Co-authored-by: Yulian Lyubomirov Cenov ycenov@arfima.com
Signed-off-by: Juan Román Roche jroman@arfimaconsulting.com