Skip to content

feat: support string parameters in permits#1123

Open
stonelgh wants to merge 1 commit into
ory:masterfrom
stonelgh:feat-string-param
Open

feat: support string parameters in permits#1123
stonelgh wants to merge 1 commit into
ory:masterfrom
stonelgh:feat-string-param

Conversation

@stonelgh

Copy link
Copy Markdown
Contributor

To support string paramters and string literal arguments in permits definition

Related issue(s)

#1113

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant

CLAassistant commented Nov 10, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@zepatrik zepatrik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for putting all of this work in!
We have to consider the impacts of this for all planned and upcoming features though, as it might interfere with those. Because that is non-trivial, it might take some time. We have already thought about a similar feature btw: #319 (comment)

@stonelgh

Copy link
Copy Markdown
Contributor Author

Got that. Let me know if you need assistance.

@TomOperator

Copy link
Copy Markdown

@stonelgh I was attempting to build similar logic (GCP-style IAM) and immediately realised this is essential to decouple objects from their relations to subjects (white flag). @zepatrik this would be a significant enhancement to the specification - do we see this landing in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants