Skip to content

Create parent directory of obj file - #99

Merged
lukaszlenart merged 2 commits into
orphan-oss:masterfrom
seraphy:ensureobjdir
Dec 29, 2018
Merged

Create parent directory of obj file#99
lukaszlenart merged 2 commits into
orphan-oss:masterfrom
seraphy:ensureobjdir

Conversation

@seraphy

@seraphy seraphy commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

Before copying OBJ and LIB to the working directory, It is necessary to create their parent directories in advance.

@lukaszlenart lukaszlenart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny issue with indentation

Comment thread src/main/java/com/akathist/maven/plugins/launch4j/Launch4jMojo.java Outdated
….java

Co-Authored-By: seraphy <seraphy@seraphyware.com>
@lukaszlenart

Copy link
Copy Markdown
Collaborator

Looks good, I will merge it and prepare a new release just after Christmas :)

@lukaszlenart

Copy link
Copy Markdown
Collaborator

osm! LGTM 👍

@lukaszlenart
lukaszlenart merged commit 88ede40 into orphan-oss:master Dec 29, 2018
@seraphy
seraphy deleted the ensureobjdir branch December 31, 2018 03:45
@seraphy

seraphy commented Dec 31, 2018

Copy link
Copy Markdown
Contributor Author

arigatou gozaimashita. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants