Add custom headers and libraries to working dir - #22
Merged
Conversation
Collaborator
There was a problem hiding this comment.
It looks like unused
Collaborator
|
Great! Let's rock! 👍 |
lukaszlenart
added a commit
that referenced
this pull request
Mar 31, 2015
Add custom headers and libraries to working dir
Collaborator
|
New version under way to the Central |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there is an issue with support for custom headers and libraries. These options need to be specified relative to the working dir which is not exposed in any way using this plugin.
So, I'd like to propose this patch which will copy the given file paths into the working directory and then pass their relative location into the launch4j configuration.