Support checking Orioledb tables in pg_amcheck#66
Merged
Conversation
- Add support for extra access method and call verify_orioledb() sql function for them. - As verify_orioledb function resides in orioledb schema do necessary schema checks before the call. No changes in amcheck utility that still supports only heap and btree access methods.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pgnickb
approved these changes
May 22, 2026
Comment on lines
+180
to
+182
| "SELECT n.nspname FROM pg_catalog.pg_extension x" | ||
| "\nJOIN pg_catalog.pg_namespace n ON x.extnamespace = n.oid" | ||
| "\nWHERE x.extname = 'orioledb'"; |
There was a problem hiding this comment.
Nit:
Suggested change
| "SELECT n.nspname FROM pg_catalog.pg_extension x" | |
| "\nJOIN pg_catalog.pg_namespace n ON x.extnamespace = n.oid" | |
| "\nWHERE x.extname = 'orioledb'"; | |
| "SELECT n.nspname FROM pg_catalog.pg_extension as x" | |
| "\nJOIN pg_catalog.pg_namespace n ON x.extnamespace OPERATOR(pg_catalog.=) n.oid" | |
| "\nWHERE x.extname OPERATOR(pg_catalog.=) 'orioledb'"; |
The rest of the code isn't paranoid about qualifying the operators, so it's ok if we aren't either. Just wanted to bring this to attention.
pgnickb
approved these changes
May 22, 2026
za-arthur
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes in amcheck utility that still supports only heap and btree access methods.