fix(virtual_scroll): prevent preloaded options from bleeding into search results#1042
Open
HSAIG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1039
When using
virtual_scrollwithpreload: true, the options loaded on the initial empty query were kept inself.optionsduring subsequent searches.This caused preloaded options to appear alongside (or instead of) the actual search results.
Root cause
In
loadCallback,clearOptions(clearFilter)was always called, which preserves any option present indefault_values? including remotely preloaded ones. Those options would then show up in the dropdown during search.Solution
html_values).addOptions()before callingclearOptions(), sinceclearOptionscan only remove existing options ? it cannot restore ones that were already cleared.Two new variables are introduced:
html_values: keys of options present in the HTML markup atinitializetime, which must always survive the search filter.default_options: the actual option objects captured after the initial preload, used to restore the dropdown when search is cleared.