Add MiniMax provider routing to the PRICE API judge - #1
Open
octo-patch wants to merge 1 commit into
Open
Conversation
Register the minimax-m3 and minimax-m2.7 judge aliases, map them to a new minimax provider with the global OpenAI-compatible default endpoint, and declare their official model ids. The mainland China endpoint is selectable through the existing per-provider base_url override. Reuses the existing OpenAI-compatible chat client and multimodal message builder. Documentation and the example env are updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: The PRICE API judge routes to several providers but has no MiniMax mapping, so its MiniMax-M3 / MiniMax-M2.7 judges and MiniMax endpoints cannot be selected.
What changed
The executable PRICE API judge (
evaluation/image_gen/PRICE/scripts/eval_imgs.py) already routes judge aliases to per-provider official APIs (with an aggregator fallback) via a set of registration tables, and its OpenAI-compatible chat client and multimodal (text + image) message builder are the shared extension point. This PR registers MiniMax through those same tables, reusing the existing client and message builder without introducing a new code path:minimax-m3andminimax-m2.7judge aliases toAPI_JUDGE_MODEL_ALIASES(mapping toMiniMax-M3andMiniMax-M2.7).minimaxprovider inJUDGE_ALIAS_PROVIDER.minimaxdefault base URL (https://api.minimax.io/v1, the global OpenAI-compatible endpoint) toPROVIDER_DEFAULT_BASE_URL, with an inline note that the mainland China site (https://api.minimaxi.com/v1) can be selected via the existing per-providerbase_urloverride.JUDGE_ALIAS_OFFICIAL_MODEL_ID.Because the aliases live in
API_JUDGE_MODEL_ALIASES, they are automatically picked up by--model,--all-api-models, and thescores_of_judges.mdordering with no further wiring.Documentation was updated to match:
env.example.tomlgains a[minimax]table with the global default and the commented mainland Chinabase_urloverride.README.mddocuments the two new aliases and the global/China endpoint selection.Checks
python3 -m py_compile scripts/eval_imgs.pypython3 -m pytest tests/(1 passed)auto/officialroute resolution, official vs. aggregator model-id selection, and global-default vs. China-base_url-override endpoint selection for both models.