Skip to content

[Launchpad] Proper quicksave deletion confirmation#665

Open
EvESpirit wants to merge 1 commit into
orbitersim:mainfrom
EvESpirit:fix-quicksave
Open

[Launchpad] Proper quicksave deletion confirmation#665
EvESpirit wants to merge 1 commit into
orbitersim:mainfrom
EvESpirit:fix-quicksave

Conversation

@EvESpirit
Copy link
Copy Markdown
Contributor

(Hopefully) sufficently fixes #600. The dialogs now look like this:
Orbiter_XTzaRZXzDd
Orbiter_iObMCMtnQ1
image

If something else should be done about this I'd be happy to do it.

#ifdef _WIN32
// SHFileOperation needs an absolute path
fs::path scnpath{ fs::absolute(pLp->App()->ScnPath("Quicksave")) };
scnpath.replace_extension(); // remove ".scn"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still necessary?

}
#else
fs::path scnpath{ pLp->App()->ScnPath("Quicksave") };
scnpath.replace_extension(); // remove ".scn"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove (or add saveguards) for the "Clear quicksaves" button

2 participants