fix(desktop): load history when resuming a session#92
Merged
Conversation
Picking a past session in the sidebar showed an empty chat — the conversation
never loaded. Root cause: `sessions.resume()` in window-shim was a stub
(`{ history: [], sessionId: '' }`), there was no Rust command to read a
session's messages (only create/append/list), and ReplScreen always started
fresh with sessionId 'default'.
Wire the full path:
- Rust: add `session_read(id)` — parses the session JSONL, returns its message
lines (skips the session_meta header + any partial trailing line).
- tauri-api: `sessionRead(id)`; window-shim: implement `resume({id})` to read
the messages, adopt them into the agent (new mac-agent `resumeSession` sets
the module history + id so the next turn continues with full context AND
appends to the same file), and return them.
- repl-stream: `storedToMsgs()` reconstructs the chat view from stored messages
— assistant text + tool_use become a finalized turn, the following user
tool_result blocks attach to the cards by tool_use_id; thinking dropped.
- App: onPickSession now awaits resume, seeds ReplScreen (remounted via key)
with the reconstructed messages; new-session / switch-project / ⌘N clear it.
Adds storedToMsgs tests (reconstruction + errored-result). Verified live in
tauri dev: selecting a session now renders its prior conversation, and a
follow-up message continues it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Picking a past session in the sidebar showed an empty chat — the prior conversation never loaded (reported live).
Root cause
window-shim.tssessions.resume()was a stub returning{ history: [], sessionId: '' }.session_create/append/list_sessions).ReplScreenalways started fresh withsessionId: 'default'.Fix (full chain)
session_read(id): parses the session JSONL, returns message lines (skips thesession_metaheader + any partial trailing line).sessionRead(id); window-shim — implementresume({id}): read messages, adopt into the agent (mac-agent.resumeSessionsets module history + id so the next turn continues with full context and appends to the same file), return them.storedToMsgs()reconstructs the chat view from stored messages (assistant text + tool_use → finalized turn; followingtool_resultblocks attach to cards bytool_use_id; thinking dropped).onPickSessionawaits resume and seeds the remountedReplScreen; new-session / switch-project / ⌘N clear it.Verified
tsc -b, 26 desktop tests (incl. 2 newstoredToMsgstests), format + 0 new lint warnings, Rust builds clean.tauri dev: selecting a session now renders its conversation; a follow-up message continues it.🤖 Generated with Claude Code