chore(tooling): enforce lint in pre-commit + ignore Rust build output#76
Merged
Conversation
eslint was scanning apps/desktop/src-tauri/target/ (generated Cargo JS), producing 49 spurious errors locally — CI only escaped because it lints before cargo build. Add target/ + release-artifacts/ to the ignore list, then wire `pnpm lint` into the pre-commit hook so lint regressions are caught before they land instead of only in CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
**/target/**andrelease-artifacts/**to the ESLint ignore list. eslint was scanning the generated Cargo JS undersrc-tauri/target/, producing 49 spurious errors locally (CI only escaped because it lints beforecargo build).pnpm lintinto the husky pre-commit hook so lint regressions are caught before landing, not only in CI.Why
Foundational hygiene + base of a 4-PR stack. With this merged,
pnpm lintis 0 errors locally.Test
pnpm lint→ 0 errors (3 pre-existing unused-var warnings remain, non-blocking).🤖 Generated with Claude Code