fix(build): skip Tauri's internal bundle_dmg.sh; always use make-dmg.sh#66
Merged
Conversation
bundle_dmg.sh inside tauri-bundler is fragile when invoked twice
(leftover rw.*.dmg from prior runs breaks the second invocation, even
after cleanup). Since our sign-and-notarize.sh always rebuilds the DMG
via make-dmg.sh anyway (to embed the signed .app + apply pretty
layout), we don't need Tauri's DMG at all.
· apps/desktop/src-tauri/tauri.conf.json — bundle.targets goes
["dmg", "app"] → ["app"]. Tauri now just produces .app.
· scripts/sign-and-notarize.sh — DMG_PATH is now an expected output
path (we extract version from tauri.conf.json) instead of being
resolved from existing files. Step 7's `[ -f "$DMG_PATH" ]` check
dropped — make-dmg.sh always builds it fresh.
This makes the pipeline idempotent: any number of consecutive runs of
scripts/sign-and-notarize.sh produce identical, signed, notarized DMGs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dmgfromtauri.conf.jsonbundle.targets(keep onlyapp). Tauri'sbundle_dmg.shwas failing intermittently when stalerw.*.dmgfiles were left in the output directory by a prior failed run.scripts/sign-and-notarize.shto always build the DMG ourselves viascripts/make-dmg.sh, no longer conditional on Tauri having produced one. This gives us:tauri.conf.jsonversion).appTest plan
pnpm tauri build --target aarch64-apple-darwinproduces only.app(no failed DMG step)scripts/sign-and-notarize.shsigns + notarizes + staples.appmake-dmg.shproduces 4.2 MB DMG with persistent.DS_Store9c72c43f-0fc3-40cc-9bd7-1101aab927e2, status Accepted)spctl --assess --type open --context context:primary-signature→ "accepted, source=Notarized Developer ID"🤖 Generated with Claude Code