feat(mcp): resource support — list on connect + @server:uri expansion#115
Merged
Conversation
Implements MCP resources (DEVELOPMENT_PLAN §3.3 / BEHAVIOR_PARITY): an MCP server's resources can now be referenced from a prompt and their content is injected for the model. core (mcp/client.ts): - connectMcpServer now lists resources on connect (capability-gated; a server without `resources` — or one that errors on resources/list — yields []). McpClientHandle gains `resources: McpResourceMeta[]`. - readMcpResource(handle, uri) — reads a resource, flattens contents to text (binary blobs → `[binary …]` placeholder). - parseResourceRefs(text) — finds `@server:scheme://path` tokens (requires `://`, so it won't match emails or `@user:pass`; dedupes). - expandMcpResourceRefs(text, handles) — reads each referenced resource and appends a `<mcp-resource server=… uri=…>` block, leaving the original token in place; unknown server / read failure surface as errors, never throw. cli: - repl.ts + headless.ts expand `@server:uri` refs in the user message after MCP connect (resolved/error lines to the user). Tests: +5 (connect→list→read→expand end-to-end against a real spawned stdio server with a `resources` capability; parseResourceRefs pure cases incl. email/`@user:pass` rejection + dedup). Core suite 569 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds MCP resources (
docs/DEVELOPMENT_PLAN.md§3.3, previously deferred inBEHAVIOR_PARITY.md). An MCP server's resources can now be referenced from a prompt via@server:scheme://path, and their content is read + injected for the model.PR 1 of a pair (PR 2 = MCP prompts as slash commands).
Changes
core —
mcp/client.ts:connectMcpServerlists resources on connect — capability-gated: a server without theresourcescapability (or one that errors onresources/list) just yields[].McpClientHandlegainsresources: McpResourceMeta[].readMcpResource(handle, uri)— reads a resource and flattens itscontentsto text; binary blobs render as a[binary <mime> <uri>]placeholder.parseResourceRefs(text)— finds@server:scheme://pathtokens. Requires://so it won't match emails or@user:pass; dedupes by raw token.expandMcpResourceRefs(text, handles)— reads each referenced resource and appends a<mcp-resource server=… uri=…>block, leaving the original token in place so the model sees what was referenced. Unknown server / read failure surface aserrors[], never throw.cli —
repl.ts+headless.ts: expand@server:urirefs in the user message right after MCP connect, printing resolved/error lines.Tests
+5 (
client.test.ts):resourcescapability: connect →handle.resourcespopulated →readMcpResourcereturns text →expandMcpResourceRefsappends the tagged block (original token kept) → unknown-server + missing-uri become errors without throwing.parseResourceRefspure cases: multi-ref extraction, email/@user:passrejection, dedup, empty.Core suite 569 green (+5); CLI 72 green; full repo suite green via pre-commit.
Notes
writeFakeServertest helper gained an optionalresourcesarg (backward-compatible — existing callers unaffected).resources/templates) and the desktop file-panel surfacing are not included; this covers the@server:uriprompt path.🤖 Generated with Claude Code