feat(sense): gate the screen-advisor on screen consent (close the capture gap)#98
Merged
Merged
Conversation
…apture gap) S2 follow-up. The screen-advisor captures a FULL screenshot → model, but was gated only by its own enabled flag — bypassing the consent framework that now governs all other screen capture. Close the gap: screenTick requires the `screen` consent grant IN ADDITION to advisor-enabled, re-checked each tick so `revoke-all` stops it within one interval. Unifies all screen capture under consent (FOUNDATIONS §1). Logs a clear hint when enabled-but-not-granted. Also records the S2 landing status honestly in PLAN_SENSE_S2 (§8, narrative = code): what shipped (consent framework, SenseSource/Service, S2-screen app-name signal, S2-voice push-to-talk, screenshot path now consent-gated, lisa sense + island feed) and what's deliberately deferred with rationale (screenshot local-first judgment, always-on voice, local STT/whisper.cpp, clipboard/ selection sources — registered in consent but source not yet built). 682 tests pass; typecheck + build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
S2 follow-up + a real privacy-gap fix. The screen-advisor captures a full screenshot → model, but was gated only by its own
enabledflag — bypassing the consent framework that now governs every other screen capture (ScreenSource, etc.).How
screenTicknow requires thescreenconsent grant in addition to advisor-enabled, re-checked each tick sorevoke-allstops it within one interval. This unifies all screen capture under consent (FOUNDATIONS §1). A clear startup hint logs when the advisor is enabled butscreenisn't granted.PLAN_SENSE_S2_v1.0.md§8 — records the S2 landing status honestly (narrative = code):SenseSource/SenseService, S2-screen (app-name signal), S2-voice (push-to-talk), screenshot path now consent-gated,lisa sense+ island feed.clipboard/selectionsources (registered in consent, source not yet built).Why this is the right S2 follow-up to ship
Always-on mic and local-STT bundling are the riskiest / least-verifiable items to build unattended, so they're documented as deferred rather than half-built. Closing the screenshot consent gap is small, safe, and the highest-value remaining S2 item — it makes the privacy story actually hold.
Verification
npm run typecheckclean,npm run buildclean, 682 tests pass🤖 Generated with Claude Code