Skip to content

chore: store provenance asset info#975

Merged
benmss merged 8 commits into
mainfrom
819-store-provenance-asset-info
May 29, 2025
Merged

chore: store provenance asset info#975
benmss merged 8 commits into
mainfrom
819-store-provenance-asset-info

Conversation

@benmss

@benmss benmss commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

This PR adds provenance asset info to the database alongside the provenance it identifies. This was previously removed during refactoring.

Closes #819

@benmss benmss self-assigned this Feb 3, 2025
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 3, 2025
@benmss benmss marked this pull request as ready for review February 4, 2025 00:16
@benmss benmss force-pushed the 819-store-provenance-asset-info branch from 7ced4d8 to 03ae1b2 Compare March 12, 2025 01:17
@benmss benmss changed the base branch from staging to main April 8, 2025 06:39
@benmss benmss force-pushed the 819-store-provenance-asset-info branch from 03ae1b2 to ede14d0 Compare April 8, 2025 07:13
Comment thread src/macaron/database/table_definitions.py
@benmss benmss force-pushed the 819-store-provenance-asset-info branch from ede14d0 to e708d81 Compare April 27, 2025 23:53
@benmss benmss linked an issue Apr 30, 2025 that may be closed by this pull request
@benmss benmss requested a review from behnazh-w May 19, 2025 02:34
@benmss benmss force-pushed the 819-store-provenance-asset-info branch from e708d81 to 25bf1c1 Compare May 21, 2025 00:11

@behnazh-w behnazh-w left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add an integration test that checks the values stored in the Provenance and ProvenanceAvailableFacts tables.

Comment thread src/macaron/slsa_analyzer/checks/provenance_available_check.py Outdated
@benmss benmss force-pushed the 819-store-provenance-asset-info branch 2 times, most recently from 7be570e to dc25a80 Compare May 26, 2025 03:03
benmss added 8 commits May 28, 2025 22:56
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss benmss force-pushed the 819-store-provenance-asset-info branch from dc25a80 to af25794 Compare May 28, 2025 13:03
@benmss benmss merged commit 256fd0c into main May 29, 2025
9 checks passed
@benmss benmss deleted the 819-store-provenance-asset-info branch May 29, 2025 05:19
AmineRaouane pushed a commit to AmineRaouane/macaron that referenced this pull request Jun 17, 2025
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store information about the provenance asset

2 participants