Skip to content

docs: make minor formatting fixes#1098

Merged
benmss merged 2 commits into
mainfrom
benmss/small-fixes-semgrep
Jun 20, 2025
Merged

docs: make minor formatting fixes#1098
benmss merged 2 commits into
mainfrom
benmss/small-fixes-semgrep

Conversation

@benmss

@benmss benmss commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR fixes various formatting issues in comments throughout the code base.

@benmss benmss self-assigned this Jun 4, 2025
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 4, 2025
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from ffaa219 to 66981ec Compare June 4, 2025 06:23
@benmss benmss assigned art1f1c3R and unassigned benmss Jun 4, 2025
@art1f1c3R

Copy link
Copy Markdown

The changes in this PR seem fine to me, but I would like to try get an idea of how to reproduce the problem and how the rule ID path caused errors in the unit tests?

@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from 66981ec to cbbecde Compare June 19, 2025 04:13
@benmss benmss assigned benmss and unassigned art1f1c3R Jun 19, 2025
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from cbbecde to 2ae183b Compare June 19, 2025 04:22
@benmss benmss changed the title chore: semgrep test fixes and minor formatting fixes chore: minor formatting fixes Jun 20, 2025
@benmss

benmss commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

The changes in this PR seem fine to me, but I would like to try get an idea of how to reproduce the problem and how the rule ID path caused errors in the unit tests?

This comment relates to the semgrep fix that was previously included in this PR. Further investigation led to removal of this "fix".

@benmss benmss marked this pull request as ready for review June 20, 2025 00:32
@benmss benmss requested review from behnazh-w and tromai as code owners June 20, 2025 00:32
@behnazh-w

behnazh-w commented Jun 20, 2025

Copy link
Copy Markdown
Member

@benmss Thanks for the PR. Can you please adjust the PR title to reflect the changes. I think docs would be a more suitable scope.

@benmss benmss changed the title chore: minor formatting fixes docs: minor formatting fixes Jun 20, 2025
@behnazh-w behnazh-w changed the title docs: minor formatting fixes docs: make minor formatting fixes Jun 20, 2025
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from 2ae183b to 0e06c41 Compare June 20, 2025 02:35
benmss added 2 commits June 20, 2025 12:40
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from 0e06c41 to a8717c8 Compare June 20, 2025 02:41
@behnazh-w behnazh-w self-requested a review June 20, 2025 03:30
@benmss benmss merged commit 6a712af into main Jun 20, 2025
9 checks passed
AmineRaouane pushed a commit to AmineRaouane/macaron that referenced this pull request Jun 29, 2025
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants