feat: Auto configure computed sensitive output fields - #129
Draft
veera-adithya-d wants to merge 2 commits into
Draft
feat: Auto configure computed sensitive output fields#129veera-adithya-d wants to merge 2 commits into
veera-adithya-d wants to merge 2 commits into
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds automatic sensitive-field configuration for Terraform schema fields that are computed-only string outputs and have high-confidence secret-like names. This allows generated resources to expose those values through connection details instead of leaving secret material in normal status fields.
The heuristic is wired into the default provider resource options and applies to both cluster-scoped and namespaced providers. It intentionally excludes required, optional, and optional+computed fields so user-provided inputs are not converted into secret refs.
This also includes regenerated APIs/CRDs. For example,
oci_identity_domains_customer_secret_key.secret_keyis now mapped as a connection detail.Fixes #123
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
AutoSensitiveFieldConfiguration, including computed-only fields, required/optional exclusions, nested schemas, excluded metadata/reference names, and preserving already-sensitive fields.go test ./config.make generateand committed the generated API/CRD changes separately.