Refactor infrastructure#6
Merged
Merged
Conversation
or-yam
commented
Jun 21, 2025
or-yam
commented
Owner
- Introduce DEFAULT_SPEED and DEFAULT_LENGTH constants in config.ts
- Update CLI to accept speed and length options
- Validate and apply speed and length in logSaber function
- Define LogSaberOptions and CliOptions types for better type safety
- use Commander for argument parsing - update TypeScript target to ES2022 - replace bin entry point with new CLI script
- Refactor color argument parsing to include 'random' option - Improve logSaber function to handle color validation and progress display - Update type definitions for better TypeScript support
- Introduce DEFAULT_SPEED and DEFAULT_LENGTH constants in config.ts - Update CLI to accept speed and length options - Validate and apply speed and length in logSaber function - Define LogSaberOptions and CliOptions types for better type safety
- Introduced a new TypeScript build configuration in tsconfig.build.json. - Updated package.json scripts to use vitest for testing and adjusted build process. - Added logSaber tests using vitest and removed outdated utils.test.js. - Updated devDependencies, including types for commander and added vitest. - Enhanced type safety and project organization by restructuring tsconfig files.
or-yam
marked this pull request as ready for review
June 21, 2025 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.