feat: implement getRunTime and zero all clocks at the start of a solve#65
Merged
Merged
Conversation
Contributor
Author
|
Hello, I accidentally opened this PR on the main repository instead of my fork. We plan to review these changes internally first before submitting a proper PR to the project. Please hold off on reviewing or merging this for now. |
jdbruijn
suggested changes
Jul 4, 2025
jdbruijn
suggested changes
Jul 4, 2025
jdbruijn
left a comment
jdbruijn
left a comment
Contributor
There was a problem hiding this comment.
Some small remarks only
filipforro
changed the title
getRunTime and zeroAllClocks
Contributor
Author
|
@mtth could you please review when you have time? |
mtth
requested changes
Jul 25, 2025
mtth
left a comment
mtth
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this. A few minor requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the issue with ever-increasing solver time, which eventually leads to
TIME_LIMITas explained in jump-dev/HiGHS.jl#167