Skip to content

Fix #6186: Separate add break between binary_deployable.jar and remaining build process.#6334

Open
ShankhanilSaha wants to merge 2 commits into
oppia:developfrom
ShankhanilSaha:separate-proguard
Open

Fix #6186: Separate add break between binary_deployable.jar and remaining build process.#6334
ShankhanilSaha wants to merge 2 commits into
oppia:developfrom
ShankhanilSaha:separate-proguard

Conversation

@ShankhanilSaha

@ShankhanilSaha ShankhanilSaha commented Jul 18, 2026

Copy link
Copy Markdown
Member

Explanation

Fixes #6186

  • In build_tests.yml and stats.yml breaking adding bazel shutdown between building up-to //:oppia_flavor_binary_deploy.jar (last target before proguard gets triggered) and remaining build process to free up JVM memory and avoiding OOM issues ultimately causing proguard flakes in CI.

Essential Checklist

  • The PR title starts with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The explanation section above starts with "Fixes #bugnum: " (If this PR fixes part of an issue, use instead: "Fixes part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Summary by CodeRabbit

  • Chores
    • Improved automated Android build workflows for non-development release variants.
    • Optimized the build sequence to generate deployment artifacts before final app bundles.
    • Streamlined branch comparison builds while preserving development, alpha, beta, and GA app bundle outputs.

@ShankhanilSaha
ShankhanilSaha requested a review from a team as a code owner July 18, 2026 10:48
@ShankhanilSaha
ShankhanilSaha requested a review from manas-yu July 18, 2026 10:48
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e7d65db7-a926-4b73-b129-43c0f8bc640a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)

❌ Error creating Unit Test PR.

  • Create PR with unit tests
  • Commit unit tests in branch separate-proguard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ShankhanilSaha ShankhanilSaha self-assigned this Jul 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Results

Coverage Analysis: SKIP ⏭️

This PR did not introduce any changes to Kotlin source or test files.

To learn more, visit the Oppia Android Code Coverage wiki page

@ShankhanilSaha

Copy link
Copy Markdown
Member Author

@BenHenning I confirmed that the deployable build includes the heavy Proguard step. With this PR, the flake should be fixed because we now shut down Bazel after that step, releasing accumulated JVM memory before building the final AAB that packages the Proguard map.

@ShankhanilSaha

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@oppia oppia deleted a comment from coderabbitai Bot Jul 18, 2026
@oppia oppia deleted a comment from coderabbitai Bot Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Proguard is flaky in CI due to OOMs

3 participants