Fix #6186: Separate add break between binary_deployable.jar and remaining build process.#6334
Fix #6186: Separate add break between binary_deployable.jar and remaining build process.#6334ShankhanilSaha wants to merge 2 commits into
Conversation
…_deploy.jar in build_test.yml
oppia_flavor_binary_deploy.jar in stats.yml
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)❌ Error creating Unit Test PR.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage ReportResultsCoverage Analysis: SKIP ⏭️ This PR did not introduce any changes to Kotlin source or test files.
|
|
@BenHenning I confirmed that the deployable build includes the heavy Proguard step. With this PR, the flake should be fixed because we now shut down Bazel after that step, releasing accumulated JVM memory before building the final AAB that packages the Proguard map. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Explanation
Fixes #6186
build_tests.ymlandstats.ymlbreaking adding bazel shutdown between building up-to//:oppia_flavor_binary_deploy.jar(last target before proguard gets triggered) and remaining build process to free up JVM memory and avoiding OOM issues ultimately causing proguard flakes in CI.Essential Checklist
Summary by CodeRabbit