Fixes #6149, Fixes part of #6202: Use bazel-contrib/setup-bazel in workflows to setup bazel#6284
Conversation
📝 WalkthroughWalkthroughAll 8 GitHub Actions workflow files replace the ChangesBazel Action Replacement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build_tests.yml:
- Around line 35-37: The action reference in the setup-bazel step uses semantic
versioning (0.19.0) instead of a commit hash, which the static analysis tool
flagged as unpinned. However, since the repository consistently uses semantic
versioning for all GitHub Actions throughout the workflows, this approach is
acceptable for maintainability and consistency. If the decision is made to
enforce stricter action pinning with commit hashes, this change should be
applied consistently across all workflow files in the repository as a
coordinated security hardening effort, not in isolation.
In @.github/workflows/lesson_checks.yml:
- Around line 16-18: The bazel-contrib/setup-bazel@0.19.0 action is executing
before the repository checkout, preventing it from accessing the .bazelversion
file needed to determine the correct Bazel version to install. Move the
actions/checkout step to execute before the setup-bazel action so that the
.bazelversion file is available when the Bazel setup reads it for version
resolution and cache optimization.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 37fd19c0-6d62-4a35-9f4d-72ffd9380a66
📒 Files selected for processing (8)
.github/workflows/build_tests.yml.github/workflows/code_coverage.yml.github/workflows/issue_checks.yml.github/workflows/lesson_checks.yml.github/workflows/static_checks.yml.github/workflows/stats.yml.github/workflows/unit_tests.yml.github/workflows/wiki.yml
adhiamboperes
left a comment
There was a problem hiding this comment.
@ShankhanilSaha, this LGTM, but one of the actions is still failing. Please look into it.
|
Hi @ShankhanilSaha, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
|
The current actions wildcard patterns at the oppia org level includes |
|
@BenHenning I have re-run the workflows. |
|
Hi @ShankhanilSaha, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @ShankhanilSaha, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @ShankhanilSaha, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fixes #6149
Fixes part of #6202
abhinavsingh/setup-bazelwith bazel's ownbazel-contrib/setup-bazel.bazelisk-cache: trueto enable caching and preventing bazel being downloaded repeatedly.Essential Checklist
Summary by CodeRabbit