Skip to content

Fix #6179: Add support for Play Signals API hook-in [DO NOT MERGE]#6264

Draft
BenHenning wants to merge 1 commit into
developfrom
depend-on-age-signals-api
Draft

Fix #6179: Add support for Play Signals API hook-in [DO NOT MERGE]#6264
BenHenning wants to merge 1 commit into
developfrom
depend-on-age-signals-api

Conversation

@BenHenning

Copy link
Copy Markdown
Member

Explanation

Fixes #6179

TODO: Finish

This PR is a proof-of-concept for how to integrate with the Play Signals API. I've taken a quick pass on it but haven't actually tested it with the app yet. Note that this PR cannot be merged as-is because it's also updating the min SDK. We need to properly deprecate Lollipop (#6258) due to the Google Play Services upgrade necessary to integrate with the signals API.

A note on the implementation: the signals API basically just needs to be called (so far as my research has extended) to satisfy the Play Store requirement (hence why we don't actually do anything additional). The Oppia app doesn't strictly need to do more than this at this point in time (so the implementation is kept as simple as possible).

Essential Checklist

  • The PR title starts with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The explanation section above starts with "Fixes #bugnum: " (If this PR fixes part of an issue, use instead: "Fixes part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

This was basically 100% done by AntiGravity though some tweaking was
needed due to the Lollipop dependency issues. This commit is also
removing Lollipop support so it cannot be merged as-is, but it can still
serve as a reference.
@BenHenning

Copy link
Copy Markdown
Member Author

/cc @adhiamboperes and @seanlip

@oppiabot

oppiabot Bot commented Jun 4, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 4, 2026
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 5, 2026
@adhiamboperes adhiamboperes removed their assignment Jun 10, 2026
@oppiabot

oppiabot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 12, 2026
@BenHenning

Copy link
Copy Markdown
Member Author

Don’t close.

@oppiabot oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 16, 2026
@oppiabot

oppiabot Bot commented Jun 23, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 23, 2026
@oppiabot oppiabot Bot closed this Jun 30, 2026
@Neer-rn Neer-rn reopened this Jun 30, 2026
@oppiabot oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 30, 2026
@oppiabot

oppiabot Bot commented Jul 7, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 7, 2026
@Neer-rn Neer-rn removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 7, 2026
@oppiabot

oppiabot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 14, 2026
@Neer-rn Neer-rn removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 14, 2026
@seanlip seanlip removed their assignment Jul 16, 2026
@seanlip

seanlip commented Jul 16, 2026

Copy link
Copy Markdown
Member

@BenHenning I was assigned to this PR ... just wanted to check, anything specific you'd like me to do on it? Thanks! #6264

@oppiabot

oppiabot Bot commented Jul 23, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Corresponds to items that haven't seen a recent update and may be automatically closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Depend on Play Age Signals API [Blocked: #6258]

4 participants