Fix #6179: Add support for Play Signals API hook-in [DO NOT MERGE]#6264
Fix #6179: Add support for Play Signals API hook-in [DO NOT MERGE]#6264BenHenning wants to merge 1 commit into
Conversation
This was basically 100% done by AntiGravity though some tweaking was needed due to the Lollipop dependency issues. This commit is also removing Lollipop support so it cannot be merged as-is, but it can still serve as a reference.
|
/cc @adhiamboperes and @seanlip |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Don’t close. |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
@BenHenning I was assigned to this PR ... just wanted to check, anything specific you'd like me to do on it? Thanks! #6264 |
|
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fixes #6179
TODO: Finish
This PR is a proof-of-concept for how to integrate with the Play Signals API. I've taken a quick pass on it but haven't actually tested it with the app yet. Note that this PR cannot be merged as-is because it's also updating the min SDK. We need to properly deprecate Lollipop (#6258) due to the Google Play Services upgrade necessary to integrate with the signals API.
A note on the implementation: the signals API basically just needs to be called (so far as my research has extended) to satisfy the Play Store requirement (hence why we don't actually do anything additional). The Oppia app doesn't strictly need to do more than this at this point in time (so the implementation is kept as simple as possible).
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: